Online Tips for Web Developer/Designer

Here is the hack: Use at your own risk

From Client: “I see that if I change the Discounted Price for a product, then the price does not update on the frontend until I delete the cookies for the site. It is the same behaviour regardless if I change the discounted price using the “Discount Type” select field or just enter a value into the “Discounted Price” field. how would they see the content of their shopping basket etc….”

So what can we do to eliminate this issue for the future. First we are going to open up the files ps_product.php located under administrator/components/com_virtuemart/classes/ps_product.php, and do a search for function get_discount( $product_id ) {

Original Code

function get_discount( $product_id ) {
	global $mosConfig_lifetime;

	// We use the Session now to store the discount info for
	// each product. But this info can change regularly,
	// so we check if the session time has expired
	if( empty( $_SESSION['product_sess'][$product_id]['discount_info'] )
	|| (time() - $_SESSION['product_sess'][$product_id]['discount_info']['create_time'] )>$mosConfig_lifetime) {
		$db = new ps_DB;
		$starttime = time();
		$year = date('Y');
		$month = date('n');
		$day = date('j');
		// get the beginning time of today
		$endofday = mktime(0, 0, 0, $month, $day, $year) - 1440;

		// Get the DISCOUNT AMOUNT
		$q = "SELECT amount,is_percent FROM #__{vm}_product,#__{vm}_product_discount ";
		$q .= "WHERE product_id='$product_id' AND (start_date<='$starttime' OR start_date=0) AND (end_date>='$endofday' OR end_date=0) ";
		$q .= "AND product_discount_id=discount_id";
		$db->query( $q );
		if( $db->next_record() ) {
			$discount_info["amount"] = $db->f("amount");
			$discount_info["is_percent"] = $db->f("is_percent");
			$no_discount = false;
		}
		else {
			$discount_info["amount"] = 0;
			$discount_info["is_percent"] = 0;
			$no_discount = true;
		}
		if ($no_discount) {
			$q = "SELECT product_parent_id FROM #__{vm}_product WHERE product_id=$product_id";
			$db->query($q);
			if($db->next_record()) {
				$q = "SELECT amount,is_percent FROM #__{vm}_product,#__{vm}_product_discount ";
				$q .= "WHERE product_id='".$db->f("product_parent_id")."' AND (start_date<='$starttime' OR start_date=0) AND (end_date>='$endofday' OR end_date=0) ";
				$q .= "AND product_discount_id=discount_id";
				$db->query( $q );
				if( $db->next_record() ) {
					$discount_info["amount"] = $db->f("amount");
					$discount_info["is_percent"] = $db->f("is_percent");
				}
			}
		}                
		$discount_info['create_time'] = time();
		$_SESSION['product_sess'][$product_id]['discount_info'] = $discount_info;
		return $discount_info;
	}
	else
		return $_SESSION['product_sess'][$product_id]['discount_info'];
}

Replace With

function get_discount( $product_id ) {
	global $mosConfig_lifetime;

	// We use the Session now to store the discount info for
	// each product. But this info can change regularly,
	// so we check if the session time has expired
	// Hacked by DesignerSandbox
	// Remark this action, so it will run strict
	// if( empty( $_SESSION['product_sess'][$product_id]['discount_info'] )
	// || (time() - $_SESSION['product_sess'][$product_id]['discount_info']['create_time'] )>$mosConfig_lifetime) {
		$db = new ps_DB;
		$starttime = time();
		$year = date('Y');
		$month = date('n');
		$day = date('j');
		// get the beginning time of today
		$endofday = mktime(0, 0, 0, $month, $day, $year) - 1440;

		// Get the DISCOUNT AMOUNT
		$q = "SELECT amount,is_percent FROM #__{vm}_product,#__{vm}_product_discount ";
		$q .= "WHERE product_id='$product_id' AND (start_date<='$starttime' OR start_date=0) AND (end_date>='$endofday' OR end_date=0) ";
		$q .= "AND product_discount_id=discount_id";
		$db->query( $q );
		if( $db->next_record() ) {
			$discount_info["amount"] = $db->f("amount");
			$discount_info["is_percent"] = $db->f("is_percent");
			$no_discount = false;
		}
		else {
			$discount_info["amount"] = 0;
			$discount_info["is_percent"] = 0;
			$no_discount = true;
		}
		if ($no_discount) {
			$q = "SELECT product_parent_id FROM #__{vm}_product WHERE product_id=$product_id";
			$db->query($q);
			if($db->next_record()) {
				$q = "SELECT amount,is_percent FROM #__{vm}_product,#__{vm}_product_discount ";
				$q .= "WHERE product_id='".$db->f("product_parent_id")."' AND (start_date<='$starttime' OR start_date=0) AND (end_date>='$endofday' OR end_date=0) ";
				$q .= "AND product_discount_id=discount_id";
				$db->query( $q );
				if( $db->next_record() ) {
					$discount_info["amount"] = $db->f("amount");
					$discount_info["is_percent"] = $db->f("is_percent");
				}
			}
		}                
		$discount_info['create_time'] = time();
		$_SESSION['product_sess'][$product_id]['discount_info'] = $discount_info;
		return $discount_info;
	// }
	// else
	// 	return $_SESSION['product_sess'][$product_id]['discount_info'];
}